feat(fields): enforce name and label props #132
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: - `styled-components` has been upgraded to v6 (still in beta for now) - `theme` constant has been renamed to `THEME` - `SUI.ACCENT` constant has been renamed to `Accent` (without `SUI`) - `SUI.SIZE` constant has been renamed to `Size` (without `SUI`) - `SUI.SORT_ORDER` constant has been renamed to `SortOrder` (without `SUI`) - `SUI` constant has been removed - All props using Accent, Size or SortOrder must now use the Accent, Size and SortOrder enums instead of strings
ivangabriele
force-pushed
the
ivan/feat-fields-enforce-name-and-label-props
branch
from
c4f5a96 to
98203fe
Compare
Codecov Report
@@ Coverage Diff @@
## main #132 +/- ##
=======================================
Coverage ? 23.07%
=======================================
Files ? 5
Lines ? 143
Branches ? 37
=======================================
Hits ? 33
Misses ? 100
Partials ? 10 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.