Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#33] Implementation of new query engine integrated with AttentionBroker PR 4/4 #39

Merged
merged 3 commits into from
Nov 13, 2024

Conversation

andre-senna
Copy link
Contributor

@andre-senna andre-senna commented Nov 8, 2024

Added tests for new query engine and revised old tests for compliance with recent changes

Closes #33

@andre-senna andre-senna changed the title [#33] Implementation of new query engine integrated with AttentionBroker PR 1/4 [#33] Implementation of new query engine integrated with AttentionBroker PR 4/4 Nov 11, 2024
Copy link
Collaborator

@angeloprobst angeloprobst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we already have a ticket to remind us to add test coverage check to this repo?

@angeloprobst
Copy link
Collaborator

Do we already have a ticket to remind us to add test coverage check to this repo?

Ticket created: singnet/das#118

@andre-senna andre-senna merged commit 6b12345 into master Nov 13, 2024
@andre-senna andre-senna deleted the senna-33-5 branch November 13, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement an asynchronous query engine
3 participants