Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[c++] can_upgrade_domain #3211

Merged
merged 4 commits into from
Oct 23, 2024
Merged

[c++] can_upgrade_domain #3211

merged 4 commits into from
Oct 23, 2024

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Oct 21, 2024

Issue and/or context: As tracked on issue #2407 / [sc-51048].

Note that the intended Python and R API changes are all agreed on and finalized as described in #2407.

Changes:

  • This is can_upgrade_domain for SOMADataFrame at the C++ level

Notes for Reviewer:

@johnkerl johnkerl changed the title [c++] upgrade_domain [WIP] [c++] upgrade_domain Oct 22, 2024
@johnkerl johnkerl marked this pull request as ready for review October 22, 2024 23:31
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.91%. Comparing base (467cd7b) to head (bc8d143).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3211      +/-   ##
==========================================
+ Coverage   83.54%   83.91%   +0.36%     
==========================================
  Files          51       51              
  Lines        5434     5478      +44     
==========================================
+ Hits         4540     4597      +57     
+ Misses        894      881      -13     
Flag Coverage Δ
python 83.91% <ø> (+0.36%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 83.91% <ø> (+0.36%) ⬆️
libtiledbsoma ∅ <ø> (∅)

@johnkerl johnkerl changed the title [c++] upgrade_domain [c++] can_upgrade_domain Oct 23, 2024
libtiledbsoma/src/soma/soma_array.cc Outdated Show resolved Hide resolved
libtiledbsoma/src/soma/soma_array.h Outdated Show resolved Hide resolved
@johnkerl johnkerl merged commit 09e1b6c into main Oct 23, 2024
@johnkerl johnkerl deleted the kerl/cpp-ugr-dom branch October 23, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants