Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[c++] Trivial name-shortens in unit-test code #3125

Merged
merged 2 commits into from
Oct 4, 2024

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Oct 3, 2024

Issue and/or context: In support of issue #2407 / [sc-51048].

Changes:

1st commit: I prefer longer/clearer names often, but, these are repeated and are causing unnecessary clang-format adjustments, particularly in PRs stacked on top of this.

2nd commit: another renaming. Not worth a separate PR IMO.

Notes for Reviewer:

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.61%. Comparing base (3bc119e) to head (c425bfd).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3125      +/-   ##
==========================================
+ Coverage   86.49%   86.61%   +0.12%     
==========================================
  Files          47       47              
  Lines        4924     4924              
==========================================
+ Hits         4259     4265       +6     
+ Misses        665      659       -6     
Flag Coverage Δ
python 86.61% <ø> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 86.61% <ø> (+0.12%) ⬆️
libtiledbsoma ∅ <ø> (∅)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants