Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[r] Use cached SOMA context rather than re-creating #2988

Merged
merged 2 commits into from
Sep 12, 2024
Merged

[r] Use cached SOMA context rather than re-creating #2988

merged 2 commits into from
Sep 12, 2024

Commits on Sep 12, 2024

  1. [r] Use cached SOMA context rather than re-creating 

    Cache a SOMA context during `$new()` as a private field when
instantiating new objects. This cached context can then be used in other
methods. Note, this PR is not yet changing the UX of config/context
options. As the context from `soma_context()` is cached globally, we can
modify the global one before instantiating to test customized cached
contexts

Modified SOMA methods:
 - `TileDBObject$new()`: creates context and caches it within the object
 - `TileDBGroup$create()`: no longer caches context, instead uses cached
   context from `$new()`
 - `TileDBGroup$open()`: uses cached context rather than calling
   `soma_context()`

[SC-55084](https://app.shortcut.com/tiledb-inc/story/55084/)
    @mojaveazure
    mojaveazure committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    cb8ffe5 View commit details
    Browse the repository at this point in the history

  2. Update changelog 

    Bump develop version
Add commented existence proof via cached global context

[ci skip]
    @mojaveazure
    mojaveazure committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    bb49e43 View commit details
    Browse the repository at this point in the history