Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[c++] Remove ArrayBuffers from SOMAArray #2979

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

nguyenv
Copy link
Member

@nguyenv nguyenv commented Sep 11, 2024

Issue and/or context:

[sc-54744]

#2975

This is the first of multiple PRs that will be split out from above

Changes:

The ArrayBuffers are now fully managed by ManagedQuery and not SOMAArray

@nguyenv nguyenv force-pushed the viviannguyen/rm-arraybuffers-from-somaarray branch from ed2d099 to 35e4d27 Compare September 11, 2024 22:08
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.87%. Comparing base (ff2eb5b) to head (35e4d27).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2979      +/-   ##
==========================================
+ Coverage   89.73%   89.87%   +0.14%     
==========================================
  Files          39       39              
  Lines        4080     4080              
==========================================
+ Hits         3661     3667       +6     
+ Misses        419      413       -6     
Flag Coverage Δ
python 89.87% <ø> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 89.87% <ø> (+0.14%) ⬆️
libtiledbsoma ∅ <ø> (∅)

@nguyenv nguyenv marked this pull request as ready for review September 11, 2024 22:42
Copy link
Member

@johnkerl johnkerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nguyenv nguyenv merged commit 7039921 into main Sep 11, 2024
15 checks passed
@nguyenv nguyenv deleted the viviannguyen/rm-arraybuffers-from-somaarray branch September 11, 2024 23:54
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants