Replace Image2DCollection with MultiscaleImage in Python and C++
#2946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This required refactoring `BaseCollection` so `MultiscaleImage` and `BaseCollection` both inherit from a new `SOMAGroup`, but `MultiscaleImage` does not inherit the collection-specific methods.
jp-dark
force-pushed
the
dark/multiscaleimage
branch
from
2ccf60c
to
bdb8ea3
Compare
jp-dark
force-pushed
the
dark/multiscaleimage
branch
from
5cdd0aa
to
01c663c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## spatial #2946 +/- ##
===========================================
+ Coverage 80.05% 80.08% +0.02%
===========================================
Files 45 46 +1
Lines 4719 4755 +36
===========================================
+ Hits 3778 3808 +30
- Misses 941 947 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up the multiscale image pyramid class. It includes the following:
ImageCollectionandImage2DCollectioninto a single classMultiscaleImageCollectionmethods fromMultiscaleImage(e.g. ability to add subcollections, sparse arrays, etc.)