Proposed fix for issue where closeConnectionIfNeeded() was initiating a _markNeedsBuild() during dispose, causing exception #2595
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed fix for issue where closeConnectionIfNeeded() was initiating a _markNeedsBuild() during dispose, causing exception
Using flutter_quill
11.4.1
I was hitting this error in my flutter app, where by:dispose()
firescloseConnectionIfNeeded()
RawEditorStateTextInputClientMixin._lastKnownRemoteTextEditingValue
QuillRawEditorState._onComposingRangeChanged()
_markNeedsBuild()
becausemounted = true
stillI'm an experienced engineer outside of dart, but I've been dabbling here for a few months. This may be the way my own app is setup, bungling the process, but I dug through this for a few hours and this PR was my best attempt at a fix today.
Here's the error stack:
PR Description
Reorders
dispose()
actions, making surecomposingRange.removeListener(_onComposingRangeChanged);
fires beforecloseConnectionIfNeeded()
to avoid the latter firing the former and leading to an exception.Type of Change