Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial support for table embed #1960

Merged
merged 2 commits into from
Jun 29, 2024
Merged

Conversation

CatHood0
Copy link
Collaborator

@CatHood0 CatHood0 commented Jun 29, 2024

Description

For several versions, we have seen many people asking for support for this custom block, however, due to its complexity, implementing it is not easy. In this PR I will try to add as much support as possible so that the tables work perfectly on most platforms.

Several errors can be seen while using it, such as that when trying to delete a cell, even when there is no longer any text, it duplicates text from the QuillEdtor, or that for now, when we try to delete a row, the last one is deleted instead of the row in which we are positioned, or that could even have problems with the implementation on the Web platform

Any suggestions would be welcome

I'm still improving the implementation since the table doesn't adapt itself to different platforms

Related Issues

Fix #1735

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I titled the PR using Conventional Commits.
  • I did not modify the CHANGELOG.md nor the package version in pubspec.yaml files.
  • All existing and new tests are passing.
  • I have run the commands in ./scripts/before_push.sh and it all passed successfully

Breaking Change

Does your PR require developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
  • No, this is not a breaking change.

@CatHood0 CatHood0 changed the title Added partial support for table embed Partial support for table embed Jun 29, 2024
@singerdmx singerdmx merged commit e76de1b into singerdmx:master Jun 29, 2024
2 checks passed
@CatHood0 CatHood0 deleted the table_support branch July 11, 2024 01:44
@Paiolus
Copy link

Paiolus commented Sep 7, 2024

I need the code for this please...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Table
3 participants