Add support for html underline and videos #1955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
June 27, 2024 22:21
fix: issue where when html2md parse <em> to "_" instead of "*" that won't be detected MarkdownToDelta converter feat(test): added test for DeltaX feat: added config classes to MarkdownToDelta and html2md that allow users configure their own styles
|
Thank you for your contributions, I will review and test the changes soon. |
added 2 commits
June 28, 2024 15:47
EchoEllet
requested changes
Jun 28, 2024
added 2 commits
June 28, 2024 17:08
CatHood0
force-pushed
the
add_underline_and_video_html_support
branch
from
dcfc228
to
acf6336
Compare
|
@CatHood0 Please resolve the conflict. Please do not worry too much about where the best place is to put the code. I believe @ellet0 can always move around code to make sense OOD wise. |
|
Yeah, i'm trying to resolve the before commit t |
|
@ellet0 I am going ahead and merging this. Please feel free to patch it after this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If you try to use
DeltaX.fromHtmlwith a tag<u>to use it as a underline style, then will be removed and just pass content as plain. Videos has the same result of the before one, if you try to use an<iframe>will be paste as a plain text or removed (idk really this last one case).Related Issues
Fix #1917
Fix #1945
Improvements
Checklist
CHANGELOG.mdnor the package version inpubspec.yamlfiles../scripts/before_push.shand it all passed successfullyBreaking Change
Does your PR require developers to manually update their apps to accommodate your change?
!in the title as explained in Conventional Commits).