Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix REST fields reported as not found and reveal more info in error log #78

Merged
merged 9 commits into from
Feb 6, 2025

Conversation

dmosorast
Copy link
Contributor

Description of change

The error message (CRITICAL line) does not contain enough actionable info in the case where the REST API does not have a field that the discovery step finds in the WSDL.

This PR adds more information to that exception and marks the fields in the current API that cause this error as not available.

Manual QA steps

  • Ran requests for each of the objects to reveal all fields
  • Confirmed that with a fully selected REST catalog, at least one request per stream could be made

Risks

  • Low. This is removing fields, but it seems that they either never worked or no longer work, so I don't believe this is a breaking change.

Rollback steps

  • revert this branch

AI generated code

https://internal.qlik.dev/general/ways-of-working/code-reviews/#guidelines-for-ai-generated-code

  • this PR has been written with the help of GitHub Copilot or another generative AI tool

Copy link
Contributor

@dsprayberry dsprayberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we consider this a minor version bump if we're removing fields?

@dmosorast
Copy link
Contributor Author

@dsprayberry I went with a patch version bump because they return an error when requested, so this is more of a bug fix than a new feature semver-wise.

@dmosorast
Copy link
Contributor Author

Merging because I've confirmed the relevant test now passes locally.

@dmosorast dmosorast merged commit d72209c into master Feb 6, 2025
2 of 3 checks passed
@dmosorast dmosorast deleted the fix/add-more-info-to-invalid-value-api-response branch February 6, 2025 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants