-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix REST fields reported as not found and reveal more info in error log #78
Fix REST fields reported as not found and reveal more info in error log #78
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we consider this a minor version bump if we're removing fields?
@dsprayberry I went with a patch version bump because they return an error when requested, so this is more of a bug fix than a new feature semver-wise. |
Merging because I've confirmed the relevant test now passes locally. |
Description of change
The error message (CRITICAL line) does not contain enough actionable info in the case where the REST API does not have a field that the discovery step finds in the WSDL.
This PR adds more information to that exception and marks the fields in the current API that cause this error as not available.
Manual QA steps
Risks
Rollback steps
AI generated code
https://internal.qlik.dev/general/ways-of-working/code-reviews/#guidelines-for-ai-generated-code