Skip to content

Commit

Permalink
Fix tap-tester
Browse files Browse the repository at this point in the history
  • Loading branch information
prijendev committed Jan 20, 2025
1 parent 6ff005c commit e5484a2
Show file tree
Hide file tree
Showing 5 changed files with 17 additions and 8 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# Changelog

## 1.4.3
* Bump requests version to 2.32.3 [#77](https://github.com/singer-io/tap-zuora/pull/77)

## 1.4.2
* Don't add related_object to field_dict if unqueryable [#73](https://github.com/singer-io/tap-zuora/pull/73)

Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

setup(
name="tap-zuora",
version="1.4.2",
version="1.4.3",
description="Singer.io tap for extracting data from the Zuora API",
author="Stitch",
url="https://singer.io",
Expand Down
14 changes: 10 additions & 4 deletions tests/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ class ZuoraBaseTest(unittest.TestCase):
"JournalEntryDetailTaxationItem",
"JournalEntryDetailDebitTaxationItem",
"JournalEntryDetailInvoiceItemAdjustment",
"RevenueRecognitionEventsTransaction"
}

#BUG: https://jira.talendforge.org/browse/TDL-21812
Expand Down Expand Up @@ -136,8 +137,6 @@ def expected_metadata(self):
"Amendment": incremental_updated_date,
"BillingRun": incremental_updated_date,
"BookingTransaction": incremental_updated_date,
"ChargeMetrics": incremental_updated_date,
"ChargeMetricsRun": incremental_updated_date,
"CommunicationProfile": incremental_updated_date,
"Contact": incremental_updated_date,
"ContactSnapshot": incremental_updated_date,
Expand Down Expand Up @@ -219,6 +218,13 @@ def expected_metadata(self):
"EmailHistory": default_full,
"Fulfillment": incremental_updated_date,
"FulfillmentItem": incremental_updated_date,
"PaymentMethodToken": incremental_updated_date,
"DeliveryAdjustment": incremental_updated_date,
"SubscriptionChargeDeliverySchedule": incremental_updated_date,
"PaymentMethodPriority": incremental_updated_date,
"GatewayProfileData": incremental_updated_date,
"BillingPreviewRunResult": incremental_updated_date,
"RevenueRecognitionEventsTransaction": incremental_updated_date
}

def rest_only_streams(self):
Expand All @@ -232,8 +238,6 @@ def rest_only_streams(self):
"Amendment",
"BillingRun",
"BookingTransaction",
"ChargeMetrics",
"ChargeMetricsRun",
"CommunicationProfile",
"Contact",
"ContactSnapshot",
Expand Down Expand Up @@ -295,6 +299,8 @@ def rest_only_streams(self):
"EmailHistory",
"Fulfillment",
"FulfillmentItem",
"BillingPreviewRunResult",
"RevenueRecognitionEventsTransaction",
}

def expected_streams(self):
Expand Down
2 changes: 1 addition & 1 deletion tests/test_zuora_bookmarking.py
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ def run_test(self, api_type):

catalog_entries = [catalog for catalog in found_catalogs if catalog["tap_stream_id"] in expected_streams]

self.perform_and_verify_table_and_field_selection(conn_id, catalog_entries)
self.perform_and_verify_table_and_field_selection(conn_id, catalog_entries, select_all_fields=False)

# Run a first sync job using orchestrator
first_sync_record_count = self.run_and_verify_sync(conn_id)
Expand Down
4 changes: 2 additions & 2 deletions tests/test_zuora_start_date.py
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ def run_test(self, api_type):
test_catalogs_1_all_fields = [
catalog for catalog in found_catalogs_1 if catalog.get("tap_stream_id") in expected_streams
]
self.perform_and_verify_table_and_field_selection(conn_id_1, test_catalogs_1_all_fields, select_all_fields=True)
self.perform_and_verify_table_and_field_selection(conn_id_1, test_catalogs_1_all_fields, select_all_fields=False)

# Run initial sync
record_count_by_stream_1 = self.run_and_verify_sync(conn_id_1)
Expand Down Expand Up @@ -77,7 +77,7 @@ def run_test(self, api_type):
test_catalogs_2_all_fields = [
catalog for catalog in found_catalogs_2 if catalog.get("tap_stream_id") in expected_streams
]
self.perform_and_verify_table_and_field_selection(conn_id_2, test_catalogs_2_all_fields, select_all_fields=True)
self.perform_and_verify_table_and_field_selection(conn_id_2, test_catalogs_2_all_fields, select_all_fields=False)

# Run sync
record_count_by_stream_2 = self.run_and_verify_sync(conn_id_2)
Expand Down

0 comments on commit e5484a2

Please sign in to comment.