Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use mambu api v2 for loan repayments now loan schedule #121

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

RumoneAndersonCornerstone

Description of change

Tap was still using version 1 of the mambu api for loan_repayments endpoint. Mambu changed the route and the schema

Mambu change documentation

Fix

  • Updated to conform to requirements mambu api v2

Manual QA steps

  • Verified the fix with the tool singer-check-taps
  • Verified the results of executing with target-csv

Risks

Rollback steps

  • revert this branch

@singer-bot
Copy link

Hi @RumoneAndersonCornerstone, thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

@RumoneAndersonCornerstone RumoneAndersonCornerstone changed the title Update Tap to use mambu api v2 for loan repayments now loan schedule Use mambu api v2 for loan repayments now loan schedule Mar 24, 2025
@singer-bot
Copy link

You did it @RumoneAndersonCornerstone!

Thank you for signing the Singer Contribution License Agreement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants