Init logger #90
Open
Init logger #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only initialize the logger once, and only if the _INIT_LOGGER module private variable is True. The reason for this is to allow client applications to override logging with custom formatters (& more) when necessary. For instance, to use eliot[1] to log but take advantage of the metrics and timers supplied by singer-python. [1] eliot: https://eliot.readthedocs.io/en/stable/
An alternative would be to cache the results of get_logger, but this feels cleaner and more explicit to me.
|
+1, Seems good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initialize the singer root logger once
Only initialize the logger once, and only if the _INIT_LOGGER module private
variable is True. The reason for this is to allow client applications to
override logging with custom formatters (& more) when necessary. For instance,
to use eliot[1] to log but take advantage of the metrics and timers supplied by
singer-python.
[1] eliot: https://eliot.readthedocs.io/en/stable/
Disable pylint global warning for _INIT_LOGGER
An alternative would be to cache the results of get_logger, but this feels
cleaner and more explicit to me.