Added R-Shiny to the Front-End Development secion. #1069
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
Please read the guidelines more closely. Multiple points not followed from it. Try going through the list point for point and check that you follow it. :) |
|
Hi @sindresorhus a number of changes have been made over the last couple of weeks, many to address the awesome guidelines. Would you be able to take another look at this PR and advise on any points we're still not meeting? |
sindresorhus
force-pushed
the
master
branch
4 times, most recently
from
1f9bc89 to
4499229
Compare
|
Hey, sorry for the lack of response, please see #1363. |
| - [Hyperapp](https://github.com/hyperapp/awesome-hyperapp) - Tiny JavaScript library for building web apps. | ||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
This line is not needed, please remove it
| @@ -230,9 +230,11 @@ | |||
| - [Preact](https://github.com/ooade/awesome-preact) - App framework. | |||
| - [Progressive Enhancement](https://github.com/jbmoelker/progressive-enhancement-resources) | |||
| - [Next.js](https://github.com/unicodeveloper/awesome-nextjs) - Framework for server-rendered React apps. | |||
| - [R-Shiny](https://github.com/grabear/awesome-rshiny) - Web Framework built with R. | |||
There was a problem hiding this comment.
As per rules in https://github.com/sindresorhus/awesome/blob/master/pull_request_template.md#requirements-for-your-pull-request you should add the entry in the end of the category, so you need to add it after Hyperapp
There was a problem hiding this comment.
also, you should add #readme in the end of the link and make sure it is linked proprly
There was a problem hiding this comment.
No need to specify the section name in your PR title, please rename it from Added R-Shiny to the Front-End Development secion. to Add R-Shiny
There was a problem hiding this comment.
please also rebase your PR as it has conflicts currently
DanailMinchev
suggested changes
Aug 14, 2018
There was a problem hiding this comment.
Hi @grabear ,
I am reviewing the latest version, currently - https://github.com/grabear/awesome-rshiny/tree/01feb1e2cf85b7c3fdc7004ddab6248616ede50a
I have added few comments about your PR and below are comments about your repository https://github.com/grabear/awesome-rshiny:
Some of the issues are:
- Add heading "Contents"
Has a Table of Contents section.
Should be named Contents, not Table of Contents.
Should be the first section in the list.
Should only have one level of sub-lists, preferably none.
-
Missing "License" section
-
Text "StackOverflow" should be written as "Stack Overflow"
-
Text "javascript" should be written as "JavaScript"
-
Don’t use multiple top level headings (you should use only one
#heading)
most of them are minor, except the "Contents" section.
You can also automatically verify your repo using following tool - https://github.com/sindresorhus/awesome-lint
I did the report for you and here is the full report for https://github.com/grabear/awesome-rshiny/tree/01feb1e2cf85b7c3fdc7004ddab6248616ede50a :
$ awesome-lint README.md
README.md:9:5
✖ 1:1 Missing file contributing.md awesome/contributing
✖ 1:1 Missing License section awesome/license
✖ 1:1 Missing or invalid Table of Contents awesome/toc
✖ 1:247 Invalid badge source awesome/badge
✖ 6:1 Don’t add a trailing ! to headings no-heading-punctuation
✖ 8:3 Invalid list item link URL awesome/list-item
✖ 9:5 Incorrect indentation before bullet: remove 2 spaces list-item-bullet-indent
✖ 9:7 Invalid list item link URL awesome/list-item
✖ 10:5 Incorrect indentation before bullet: remove 2 spaces list-item-bullet-indent
✖ 10:7 Invalid list item link URL awesome/list-item
✖ 11:5 Incorrect indentation before bullet: remove 2 spaces list-item-bullet-indent
✖ 11:7 Invalid list item link URL awesome/list-item
✖ 12:5 Incorrect indentation before bullet: remove 2 spaces list-item-bullet-indent
✖ 12:7 Invalid list item link URL awesome/list-item
✖ 13:3 Invalid list item link URL awesome/list-item
✖ 14:5 Incorrect indentation before bullet: remove 2 spaces list-item-bullet-indent
✖ 14:7 Invalid list item link URL awesome/list-item
✖ 15:5 Incorrect indentation before bullet: remove 2 spaces list-item-bullet-indent
✖ 15:7 Invalid list item link URL awesome/list-item
✖ 16:3 Invalid list item link URL awesome/list-item
✖ 17:3 Invalid list item link URL awesome/list-item
✖ 18:3 Invalid list item link URL awesome/list-item
✖ 19:3 Invalid list item link URL awesome/list-item
✖ 20:3 Invalid list item link URL awesome/list-item
✖ 23:1 Don’t use multiple top level headings (1:1) no-multiple-toplevel-headings
✖ 27:1 Marker style should be - unordered-list-marker-style
✖ 27:48 List item link and description must be separated with a dash awesome/list-item
✖ 28:2 Don’t pad emphasis with inner spaces no-inline-padding
✖ 30:2 Don’t pad emphasis with inner spaces no-inline-padding
✖ 32:2 Don’t pad emphasis with inner spaces no-inline-padding
✖ 34:1 Marker style should be - unordered-list-marker-style
✖ 38:1 Marker style should be - unordered-list-marker-style
✖ 39:1 Marker style should be - unordered-list-marker-style
✖ 39:4 Text "StackOverflow" should be written as "Stack Overflow" awesome/spell-check
✖ 40:1 Marker style should be - unordered-list-marker-style
✖ 41:1 Marker style should be - unordered-list-marker-style
✖ 42:1 Marker style should be - unordered-list-marker-style
✖ 43:1 Marker style should be - unordered-list-marker-style
✖ 44:1 Marker style should be - unordered-list-marker-style
✖ 45:1 Marker style should be - unordered-list-marker-style
✖ 51:1 Marker style should be - unordered-list-marker-style
✖ 52:1 Marker style should be - unordered-list-marker-style
✖ 53:1 Marker style should be - unordered-list-marker-style
✖ 58:1 Marker style should be - unordered-list-marker-style
✖ 59:1 Marker style should be - unordered-list-marker-style
✖ 63:1 Marker style should be - unordered-list-marker-style
✖ 64:3 Marker style should be - unordered-list-marker-style
✖ 64:5 Incorrect indentation before bullet: remove 2 spaces list-item-bullet-indent
✖ 65:3 Marker style should be - unordered-list-marker-style
✖ 65:5 Incorrect indentation before bullet: remove 2 spaces list-item-bullet-indent
✖ 66:3 Marker style should be - unordered-list-marker-style
✖ 66:5 Incorrect indentation before bullet: remove 2 spaces list-item-bullet-indent
✖ 67:3 Marker style should be - unordered-list-marker-style
✖ 67:5 Incorrect indentation before bullet: remove 2 spaces list-item-bullet-indent
✖ 68:3 Marker style should be - unordered-list-marker-style
✖ 68:5 Incorrect indentation before bullet: remove 2 spaces list-item-bullet-indent
✖ 69:3 Marker style should be - unordered-list-marker-style
✖ 69:5 Incorrect indentation before bullet: remove 2 spaces list-item-bullet-indent
✖ 70:1 Marker style should be - unordered-list-marker-style
✖ 71:3 Marker style should be - unordered-list-marker-style
✖ 71:5 Incorrect indentation before bullet: remove 2 spaces list-item-bullet-indent
✖ 71:58 List item link and description must be separated with a dash awesome/list-item
✖ 72:2 Don’t pad emphasis with inner spaces no-inline-padding
✖ 74:2 Don’t pad emphasis with inner spaces no-inline-padding
✖ 76:2 Don’t pad emphasis with inner spaces no-inline-padding
✖ 78:2 Don’t pad emphasis with inner spaces no-inline-padding
✖ 80:2 Don’t pad emphasis with inner spaces no-inline-padding
✖ 83:1 Marker style should be - unordered-list-marker-style
✖ 84:1 Marker style should be - unordered-list-marker-style
✖ 85:1 Marker style should be - unordered-list-marker-style
✖ 85:40 List item link and description must be separated with a dash awesome/list-item
✖ 86:2 Don’t pad emphasis with inner spaces no-inline-padding
✖ 88:1 Marker style should be - unordered-list-marker-style
✖ 88:40 List item link and description must be separated with a dash awesome/list-item
✖ 89:2 Don’t pad emphasis with inner spaces no-inline-padding
✖ 91:2 Don’t pad emphasis with inner spaces no-inline-padding
✖ 93:2 Don’t pad emphasis with inner spaces no-inline-padding
✖ 95:2 Don’t pad emphasis with inner spaces no-inline-padding
✖ 98:1 Marker style should be - unordered-list-marker-style
✖ 98:45 List item link and description must be separated with a dash awesome/list-item
✖ 99:2 Don’t pad emphasis with inner spaces no-inline-padding
✖ 101:1 Marker style should be - unordered-list-marker-style
✖ 102:1 Marker style should be - unordered-list-marker-style
✖ 103:1 Marker style should be - unordered-list-marker-style
✖ 104:1 Marker style should be - unordered-list-marker-style
✖ 105:1 Marker style should be - unordered-list-marker-style
✖ 106:1 Marker style should be - unordered-list-marker-style
✖ 107:1 Marker style should be - unordered-list-marker-style
✖ 108:1 Marker style should be - unordered-list-marker-style
✖ 109:1 Marker style should be - unordered-list-marker-style
✖ 110:1 Marker style should be - unordered-list-marker-style
✖ 111:1 Marker style should be - unordered-list-marker-style
✖ 112:1 Marker style should be - unordered-list-marker-style
✖ 113:1 Marker style should be - unordered-list-marker-style
✖ 114:1 Marker style should be - unordered-list-marker-style
✖ 115:1 Marker style should be - unordered-list-marker-style
✖ 117:1 Don’t use multiple top level headings (1:1) no-multiple-toplevel-headings
✖ 121:1 Marker style should be - unordered-list-marker-style
✖ 121:3 Invalid list item link URL awesome/list-item
✖ 122:2 Don’t pad emphasis with inner spaces no-inline-padding
✖ 124:2 Don’t pad emphasis with inner spaces no-inline-padding
✖ 126:1 Marker style should be - unordered-list-marker-style
✖ 126:65 List item description must end with proper punctuation awesome/list-item
✖ 127:1 Marker style should be - unordered-list-marker-style
✖ 128:1 Marker style should be - unordered-list-marker-style
✖ 129:1 Marker style should be - unordered-list-marker-style
✖ 129:49 Text "javascript" should be written as "JavaScript" awesome/spell-check
✖ 130:1 Marker style should be - unordered-list-marker-style
✖ 131:1 Marker style should be - unordered-list-marker-style
✖ 132:1 Marker style should be - unordered-list-marker-style
✖ 133:1 Marker style should be - unordered-list-marker-style
✖ 134:1 Marker style should be - unordered-list-marker-style
✖ 135:1 Marker style should be - unordered-list-marker-style
✖ 136:1 Marker style should be - unordered-list-marker-style
✖ 137:1 Marker style should be - unordered-list-marker-style
✖ 138:1 Marker style should be - unordered-list-marker-style
✖ 139:1 Marker style should be - unordered-list-marker-style
✖ 140:1 Marker style should be - unordered-list-marker-style
✖ 141:1 Marker style should be - unordered-list-marker-style
✖ 142:1 Marker style should be - unordered-list-marker-style
✖ 143:1 Marker style should be - unordered-list-marker-style
✖ 144:1 Marker style should be - unordered-list-marker-style
✖ 145:1 Marker style should be - unordered-list-marker-style
✖ 145:55 List item description must start with valid casing awesome/list-item
✖ 146:1 Marker style should be - unordered-list-marker-style
✖ 147:1 Marker style should be - unordered-list-marker-style
✖ 148:1 Marker style should be - unordered-list-marker-style
✖ 149:1 Marker style should be - unordered-list-marker-style
✖ 150:1 Marker style should be - unordered-list-marker-style
✖ 151:1 Marker style should be - unordered-list-marker-style
✖ 152:1 Marker style should be - unordered-list-marker-style
✖ 153:1 Marker style should be - unordered-list-marker-style
✖ 157:1 Marker style should be - unordered-list-marker-style
✖ 158:1 Marker style should be - unordered-list-marker-style
✖ 158:4 Text "Javascript" should be written as "JavaScript" awesome/spell-check
✖ 158:57 List item link and description must be separated with a dash awesome/list-item
✖ 159:2 Don’t pad emphasis with inner spaces no-inline-padding
✖ 160:75 Text "javascript" should be written as "JavaScript" awesome/spell-check
✖ 161:2 Don’t pad emphasis with inner spaces no-inline-padding
✖ 163:2 Don’t pad emphasis with inner spaces no-inline-padding
✖ 165:2 Don’t pad emphasis with inner spaces no-inline-padding
✖ 167:2 Don’t pad emphasis with inner spaces no-inline-padding
✖ 169:2 Don’t pad emphasis with inner spaces no-inline-padding
✖ 171:2 Don’t pad emphasis with inner spaces no-inline-padding
✖ 173:2 Don’t pad emphasis with inner spaces no-inline-padding
✖ 175:1 Marker style should be - unordered-list-marker-style
✖ 176:1 Marker style should be - unordered-list-marker-style
✖ 177:1 Marker style should be - unordered-list-marker-style
✖ 178:1 Marker style should be - unordered-list-marker-style
✖ 179:1 Marker style should be - unordered-list-marker-style
✖ 180:1 Marker style should be - unordered-list-marker-style
✖ 182:1 Don’t use multiple top level headings (1:1) no-multiple-toplevel-headings
✖ 184:1 Marker style should be - unordered-list-marker-style
✖ 185:1 Marker style should be - unordered-list-marker-style
✖ 186:1 Marker style should be - unordered-list-marker-style
✖ 187:1 Marker style should be - unordered-list-marker-style
✖ 188:1 Marker style should be - unordered-list-marker-style
✖ 189:1 Marker style should be - unordered-list-marker-style
✖ 190:1 Marker style should be - unordered-list-marker-style
✖ 191:1 Marker style should be - unordered-list-marker-style
✖ 193:1 Don’t use multiple top level headings (1:1) no-multiple-toplevel-headings
✖ 195:1 Marker style should be - unordered-list-marker-style
✖ 196:1 Marker style should be - unordered-list-marker-style
✖ 198:1 Don’t use multiple top level headings (1:1) no-multiple-toplevel-headings
✖ 200:1 Marker style should be - unordered-list-marker-style
✖ 200:3 Invalid list item link URL awesome/list-item
✖ 201:2 Don’t pad emphasis with inner spaces no-inline-padding
✖ 203:1 Marker style should be - unordered-list-marker-style
✖ 204:1 Marker style should be - unordered-list-marker-style
✖ 205:1 Marker style should be - unordered-list-marker-style
✖ 205:3 Invalid list item link URL awesome/list-item
✖ 206:2 Don’t pad emphasis with inner spaces no-inline-padding
✖ 208:1 Marker style should be - unordered-list-marker-style
✖ 210:1 Don’t use multiple top level headings (1:1) no-multiple-toplevel-headings
✖ 212:1 Marker style should be - unordered-list-marker-style
✖ 213:1 Marker style should be - unordered-list-marker-style
✖ 214:1 Marker style should be - unordered-list-marker-style
✖ 215:1 Marker style should be - unordered-list-marker-style
✖ 216:1 Marker style should be - unordered-list-marker-style
✖ 216:77 List item description must start with valid casing awesome/list-item
✖ 217:1 Marker style should be - unordered-list-marker-style
✖ 218:1 Marker style should be - unordered-list-marker-style
✖ 219:1 Marker style should be - unordered-list-marker-style
✖ 220:1 Marker style should be - unordered-list-marker-style
✖ 221:1 Marker style should be - unordered-list-marker-style
✖ 222:1 Marker style should be - unordered-list-marker-style
✖ 223:1 Marker style should be - unordered-list-marker-style
✖ 224:1 Marker style should be - unordered-list-marker-style
✖ 225:1 Marker style should be - unordered-list-marker-style
✖ 226:1 Marker style should be - unordered-list-marker-style
✖ 227:1 Marker style should be - unordered-list-marker-style
✖ 227:49 List item description must start with valid casing awesome/list-item
✖ 228:1 Marker style should be - unordered-list-marker-style
✖ 229:1 Marker style should be - unordered-list-marker-style
✖ 230:1 Marker style should be - unordered-list-marker-style
✖ 231:1 Marker style should be - unordered-list-marker-style
✖ 232:1 Marker style should be - unordered-list-marker-style
✖ 233:2 Don’t pad emphasis with inner spaces no-inline-padding
✖ 235:1 Marker style should be - unordered-list-marker-style
✖ 236:1 Marker style should be - unordered-list-marker-style
✖ 237:1 Marker style should be - unordered-list-marker-style
✖ 238:1 Marker style should be - unordered-list-marker-style
✖ 239:1 Marker style should be - unordered-list-marker-style
✖ 240:1 Marker style should be - unordered-list-marker-style
✖ 241:1 Marker style should be - unordered-list-marker-style
✖ 242:1 Marker style should be - unordered-list-marker-style
✖ 243:1 Marker style should be - unordered-list-marker-style
✖ 244:1 Marker style should be - unordered-list-marker-style
✖ 245:1 Marker style should be - unordered-list-marker-style
✖ 246:1 Marker style should be - unordered-list-marker-style
✖ 247:1 Marker style should be - unordered-list-marker-style
✖ 248:1 Marker style should be - unordered-list-marker-style
✖ 250:1 Don’t use multiple top level headings (1:1) no-multiple-toplevel-headings
✖ 252:1 Marker style should be - unordered-list-marker-style
✖ 253:1 Marker style should be - unordered-list-marker-style
✖ 254:1 Marker style should be - unordered-list-marker-style
✖ 255:1 Marker style should be - unordered-list-marker-style
✖ 256:1 Marker style should be - unordered-list-marker-style
✖ 257:1 Marker style should be - unordered-list-marker-style
✖ 258:1 Marker style should be - unordered-list-marker-style
✖ 259:1 Marker style should be - unordered-list-marker-style
221 errors
Thanks
Merged
|
@grabear ⬆️ |
|
@sindresorus I will try to lint this myself tomorrow and make some changes. Been busy! :) |
|
Closing for lack of activity. The repo also has not been updated since mid last year. |
grabear
added a commit
to grabear/awesome-rshiny
that referenced
this pull request
Aug 14, 2020
Created custom hex-sticker. Fixed items from sindresorhus/awesome#1069
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/grabear/awesome-rshiny
This awesome list is a compilation of useful R-Shiny resources. R-shiny has been available for several years now, and has evolved into a highly useful package for Data Scientists who are not necessarily familiar with web development. It gives these scientist an opportunity to create great web application for their publications and affiliated institutions. Accepting this link into the Front End Development section will bring more awareness to the inherit usefulness of Shiny as a web framework.
By submitting this pull request I confirm I've read and complied with the below requirements.
Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.
For example,
Add Name of List, notUpdate readme.mdorAdd awesome list.Example:
- [Fish](…) - User-friendly shell., not- [Fish](…) - Resources for Fish..That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
awesome-list&awesomeas GitHub topics. I encourage you to add more relevant topics.Contents, notTable of Contents.contributing.md. Casing is up to you.Example:
- [AVA](…) - JavaScript test runner.A/Anprefixes in the descriptions.Node.js, notNodeJSornode.js.You can still use Travis for list linting, but the badge has no value in the readme.