Feat/fax api faxes (#48) #72
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The versions of the `Microsoft.Extensions.Http` and `System.Text.Json` packages in the `Sinch.csproj` file have been updated. * feat: add FaxRegion and resolve url based on it * refactor: create fax request take either content url, stream or filePath * refactor: list query create query param * feat: add fax autolist * chore: add string output to debug for json responses * feat: upload fax as multipart/form data * feat:process other kind of api error * feat: impl get fax * feat: implement download fax, add example * feat: implement delete * feat: implement list * feat: add fax mock service * chore(http): add test for multipart content * feat: for last page add calculate if first page starting at 1 * chore: add comment for unused StreamExtensions.cs * feat: add multiple or single send fax * feat: return contentresult with stream and filename for content download --------- Co-authored-by: spacedsweden <[email protected]>
* feat: add support for fax emails
* feat(fax): support services Move service emails list implementation to Services
* feat: add fax hooks
* feat: add support for sending base64 files with contentUrl prop independently
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main PR for fax api support
The versions of the
Microsoft.Extensions.HttpandSystem.Text.Jsonpackages has been updated to 8.0feat: add FaxRegion and resolve url based on it
refactor: create fax request take either content url, stream or filePath
refactor: list query create query param
feat: add fax autolist
chore: add string output to debug for json responses
feat: upload fax as multipart/form data
feat:process other kind of api error
feat: impl get fax
feat: implement download fax, add example
feat: implement delete
feat: implement list
feat: add fax mock service
chore(http): add test for multipart content
feat: for last page add calculate if first page starting at 1
chore: add comment for unused StreamExtensions.cs
feat: add multiple or single send fax
feat: return contentresult with stream and filename for content download