Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix performance issue for Mustermann::AST::Translator#escape #142

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Fix performance issue for Mustermann::AST::Translator#escape #142

merged 1 commit into from
Sep 3, 2024

Conversation

ericproulx
Copy link
Contributor

@ericproulx ericproulx commented Sep 1, 2024 •
edited by dentarg
Loading

Trying to get 100% coverage for #140

Close #140

@ericproulx ericproulx mentioned this pull request Sep 1, 2024
Closed
@ericproulx ericproulx marked this pull request as ready for review September 1, 2024 17:51
@dentarg
Copy link
Member

dentarg commented Sep 1, 2024

@hsbt what do you think about this? was there any reason you added a method in #141?

@hsbt
Copy link
Contributor

hsbt commented Sep 2, 2024

This seems okay to me. I don't want to spend my time for keeping 100% coverage.

dentarg
dentarg approved these changes Sep 3, 2024
View reviewed changes
Copy link
Member

@dentarg dentarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran mustermann/bench/uri_parser_object.rb from #141 on this change, it does not raise. It raised on main (6c9494b).

@dentarg dentarg changed the title Use constant to define URI_PARSER Fix performance issue for Mustermann::AST::Translator#escape Sep 3, 2024
@dentarg dentarg merged commit 72aaf61 into sinatra:main Sep 3, 2024
10 checks passed
@ericproulx ericproulx mentioned this pull request Sep 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dentarg dentarg dentarg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Massive performance degragation 3.0 -> 3.0.2
3 participants
@ericproulx @dentarg @hsbt