-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Add 3.0 and JRuby to the build matrix #112
Conversation
I think we could add ruby 3 now that it has released a new minor, and maybe we could add Jruby too because sinatra itself supports it |
@epergo Thought: Do you think it'd be alright to only keep version specifiers like "2.7" in the list? |
Cool! "3.0" runs, and shows several ArgumentError! https://travis-ci.org/github/sinatra/mustermann/jobs/766897981 I added a new Issue, #114 to follow this. |
JRuby fails on attempting to use redcarpet, which has a C extension. /home/travis/build/sinatra/mustermann/vendor/bundle/jruby/2.5.0/gems/redcarpet-3.5.1/ext/redcarpet This has been explored in 2017, but still needs fixing; #72 |
Sounds good, Travis will download the latest minor version As for Ruby 3 and jRuby errors, we can allow failures for them so we (aka someone with suppa powers 😄 ) can merge this |
Use short-hand names for Ruby versions.
@olleolleolle Thanks for creating this! I'm not sure about the jruby version, but I wonder if we can clean up and stop testing EoL'd versions of Ruby. |
@zzak I can drop every EOL'd version, right now. The JRuby version is latest available. https://www.jruby.org/2021/03/29/jruby-9-2-17-0.html |
See https://www.ruby-lang.org/en/downloads/branches/ for the current policy.
@zzak If you feel uneasy about adding a previously-not-there Ruby implementation, I can take that out of this PR, and move it to another Pull Request, which could be about "add JRuby to matrix AND make it pass green". How about that? |
@olleolleolle I think it's fine but I just wasn't sure |
This PR only updates the CI matrix to the latest generally available Ruby versions.
Source for version numbers: https://github.com/rvm/rvm/blob/master/config/known
Did not include
3.0.0-preview2
Update: Added JRuby & 3.0, and allowed them to run with failures.