Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Add 3.0 and JRuby to the build matrix #112

Merged
merged 3 commits into from
Apr 14, 2021
Merged

Conversation

olleolleolle
Copy link
Member

@olleolleolle olleolleolle commented Dec 17, 2020

This PR only updates the CI matrix to the latest generally available Ruby versions.

Source for version numbers: https://github.com/rvm/rvm/blob/master/config/known

Did not include 3.0.0-preview2 Update: Added JRuby & 3.0, and allowed them to run with failures.

@epergo
Copy link
Member

epergo commented Apr 13, 2021

Did not include 3.0.0-preview2

I think we could add ruby 3 now that it has released a new minor, and maybe we could add Jruby too because sinatra itself supports it

@olleolleolle
Copy link
Member Author

@epergo Thought: Do you think it'd be alright to only keep version specifiers like "2.7" in the list?

@olleolleolle
Copy link
Member Author

olleolleolle commented Apr 13, 2021

Cool! "3.0" runs, and shows several ArgumentError! https://travis-ci.org/github/sinatra/mustermann/jobs/766897981

I added a new Issue, #114 to follow this.

@olleolleolle
Copy link
Member Author

olleolleolle commented Apr 13, 2021

JRuby fails on attempting to use redcarpet, which has a C extension. /home/travis/build/sinatra/mustermann/vendor/bundle/jruby/2.5.0/gems/redcarpet-3.5.1/ext/redcarpet This has been explored in 2017, but still needs fixing; #72

@epergo
Copy link
Member

epergo commented Apr 13, 2021

@epergo Thought: Do you think it'd be alright to only keep version specifiers like "2.7" in the list?

Sounds good, Travis will download the latest minor version

As for Ruby 3 and jRuby errors, we can allow failures for them so we (aka someone with suppa powers 😄 ) can merge this now()

Use short-hand names for Ruby versions.
@olleolleolle olleolleolle changed the title CI: Update patch versions of Ruby in the matrix CI: Add 3.0 and JRuby to the build matrix Apr 13, 2021
@zzak
Copy link
Member

zzak commented Apr 13, 2021

@olleolleolle Thanks for creating this!

I'm not sure about the jruby version, but I wonder if we can clean up and stop testing EoL'd versions of Ruby.

@olleolleolle
Copy link
Member Author

olleolleolle commented Apr 13, 2021

@zzak I can drop every EOL'd version, right now.

The JRuby version is latest available. https://www.jruby.org/2021/03/29/jruby-9-2-17-0.html

@olleolleolle
Copy link
Member Author

olleolleolle commented Apr 13, 2021

@zzak If you feel uneasy about adding a previously-not-there Ruby implementation, I can take that out of this PR, and move it to another Pull Request, which could be about "add JRuby to matrix AND make it pass green". How about that?

@zzak
Copy link
Member

zzak commented Apr 14, 2021

@olleolleolle I think it's fine but I just wasn't sure

@zzak zzak merged commit cd71bbc into sinatra:master Apr 14, 2021
@olleolleolle olleolleolle deleted the patch-2 branch April 14, 2021 06:16
@olleolleolle olleolleolle mentioned this pull request Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants