fix(desktop): manage signing keychain explicitly - #7411
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
Greptile SummaryThe PR moves macOS Developer ID credentials into an explicitly managed temporary keychain to avoid electron-builder’s keychain-password regression.
Confidence Score: 5/5The PR appears safe to merge with no actionable correctness or security issues identified. The packaging step receives only the explicitly prepared keychain, its access configuration matches the expected electron-builder signing flow, and cleanup does not interfere with subsequent artifact verification.
|
| Filename | Overview |
|---|---|
| .github/workflows/desktop-release.yml | Explicitly manages the temporary signing keychain, limits credential scope between workflow steps, and performs unconditional credential cleanup without introducing an actionable failure. |
Reviews (1): Last reviewed commit: "fix(desktop): manage signing keychain ex..." | Re-trigger Greptile
Summary
set-key-partition-listregressionCSC_KEYCHAINto electron-builder, validate the signing identity before packaging, and always remove temporary signing credentialsType of Change
Testing
set-key-partition-listagainst a disposable.p12and temporary keychain on macOSChecklist