Skip to content

fix(desktop): manage signing keychain explicitly - #7411

Merged
waleedlatif1 merged 1 commit into
stagingfrom
codex/desktop-signing-keychain
Sep 2, 2026
Merged

fix(desktop): manage signing keychain explicitly#7411
waleedlatif1 merged 1 commit into
stagingfrom
codex/desktop-signing-keychain

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • import the Developer ID certificate into an explicit temporary macOS keychain
  • keep the certificate password separate from the generated keychain password, avoiding the electron-builder 26.15.3 set-key-partition-list regression
  • pass only CSC_KEYCHAIN to electron-builder, validate the signing identity before packaging, and always remove temporary signing credentials

Type of Change

  • Bug fix

Testing

  • signed, non-publishing Desktop Release run: certificate import, universal packaging, Developer ID signing, notarization, credential cleanup, artifact validation, and packaged smoke tests passed
  • exercised certificate import and set-key-partition-list against a disposable .p12 and temporary keychain on macOS
  • actionlint with shellcheck and YAML parsing
  • 1,455 desktop tests
  • monorepo type-check, lint, 45 audits, desktop bridge/IPC checks, block registry validation, and native-binary checksum verification

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 2, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Sep 2, 2026 8:29pm UTC

Request Review

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR moves macOS Developer ID credentials into an explicitly managed temporary keychain to avoid electron-builder’s keychain-password regression.

  • Imports the certificate using separate certificate and generated keychain passwords.
  • Configures noninteractive signing access and validates the Developer ID identity before packaging.
  • Supplies only the temporary keychain to electron-builder and removes signing credentials afterward.

Confidence Score: 5/5

The PR appears safe to merge with no actionable correctness or security issues identified.

The packaging step receives only the explicitly prepared keychain, its access configuration matches the expected electron-builder signing flow, and cleanup does not interfere with subsequent artifact verification.

Important Files Changed

Filename Overview
.github/workflows/desktop-release.yml Explicitly manages the temporary signing keychain, limits credential scope between workflow steps, and performs unconditional credential cleanup without introducing an actionable failure.

Reviews (1): Last reviewed commit: "fix(desktop): manage signing keychain ex..." | Re-trigger Greptile

@waleedlatif1
waleedlatif1 merged commit d218534 into staging Sep 2, 2026
33 of 34 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/desktop-signing-keychain branch September 2, 2026 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant