fix: emcn component library design engineering polish#3672
fix: emcn component library design engineering polish#3672waleedlatif1 merged 33 commits intosimstudioai:stagingfrom
Conversation
PR SummaryLow Risk Overview Polishes a few interactions: the Enterprise feature marquee now pauses on hover and respects reduced-motion, the signup form’s field validation messages animate/collapse inline, and various skeleton/loading states and small motion parameters are adjusted for consistency. Also relaxes the docs app viewport restrictions by removing Written by Cursor Bugbot for commit 2715ffb. This will update automatically on new commits. Configure here. |
|
@adithyaakrishna is attempting to deploy a commit to the Sim Team on Vercel. A member of the Team first needs to authorize it. |
74c6b77 to
437f7fd
Compare
437f7fd to
ccbc8d8
Compare
c6eefee to
2f83f87
Compare
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
6910a7e to
66f4d5e
Compare
|
@adithyaakrishna just ping me when this is ready for review. We'll go through this together. |
f9d75a0 to
dbc546d
Compare
|
@icecrasher321 this is ready |
|
@icecrasher321 looks like these were some regressions that I missed out on, will send a fix soon |
57952ae to
9cb4acd
Compare
676a974 to
ef95212
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Greptile SummaryThis PR delivers a comprehensive design polish pass on the Confidence Score: 4/5Safe to merge after the data-popover-scroll fix; all other changes are well-scoped polish. The vast majority of changes are mechanical token renames and hover-hover class substitutions, correctly propagated across 464 files. The one genuine logic bug (popover scroll-container truncation) is narrow in scope and has a simple one-line fix. The behavioral change to toast auto-dismiss is intentional per the PR description. CSS variable renames are fully migrated with no dangling references in code. apps/sim/components/emcn/components/popover/popover.tsx (data-popover-scroll regression) Important Files Changed
|
* chore: fix conflicts * chore: fix conflicts * chore: pause marquee * chore: fix conflicts * chore: fix conflicts * chore: address review comments * chore: fix conflicts * chore: other bug fixes * chore: fix conflicts * chore: fix radius * chore: fix review changes * chore: fix conflicts * chore: revert other * chore: fix conflicts * chore: fix review changes * chore: fix conflicts * chore: fix review changes * chore: fix button state * chore: fix button state * chore: fix review changes * chore: fix lint * chore: fix conflicts * chore: add metadata * chore: fix things * chore: fix overwritten states * chore: fix warnings * chore: fix button state * chore: fix review changes * chore: fix review changes * chore: fix hover state * chore: fix popover * chore: fix review changes * chore: fix review changes




Summary
Comprehensive polish of the emcn compos library along with addressing a11y issues and design token consistency
Type of Change
Testing
Checklist