Skip to content

fix(connectors): align connector scopes with oauth config and fix kb modal UX #3573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 7 commits into from
Mar 14, 2026
Merged

fix(connectors): align connector scopes with oauth config and fix kb modal UX #3573

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f58356f
fix(connectors): align connector scopes with oauth config and fix kb …
waleedlatif1 Mar 14, 2026
9a31d9a
fix(connectors): restore onCheckedChange for keyboard accessibility
waleedlatif1 Mar 14, 2026
607b07b
feat(connectors): add dynamic selectors to knowledge base connector c…
waleedlatif1 Mar 14, 2026
4b7d9a7
updated animated blocks UI
waleedlatif1 Mar 14, 2026
31ee9a9
fix(connectors): clear canonical siblings of dependents and resolve a…
waleedlatif1 Mar 14, 2026
b4cd61a
chore: linter class ordering fixes and docs link update
waleedlatif1 Mar 14, 2026
4e1baa7
fix(connectors): reset apiKeyFocused on connector re-selection
waleedlatif1 Mar 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 5 additions & 12 deletions ...space/[workspaceId]/knowledge/[id]/components/add-connector-modal/add-connector-modal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ export function AddConnectorModal({ open, onOpenChange, knowledgeBaseId }: AddCo
const [showOAuthModal, setShowOAuthModal] = useState(false)

const [apiKeyValue, setApiKeyValue] = useState('')
const [apiKeyFocused, setApiKeyFocused] = useState(false)
const [searchTerm, setSearchTerm] = useState('')
Comment thread
waleedlatif1 marked this conversation as resolved.

const { workspaceId } = useParams<{ workspaceId: string }>()
Expand Down Expand Up @@ -235,10 +236,12 @@ export function AddConnectorModal({ open, onOpenChange, knowledgeBaseId }: AddCo
: 'API Key'}
</Label>
<Input
type='password'
type={apiKeyFocused ? 'text' : 'password'}
autoComplete='new-password'
value={apiKeyValue}
onChange={(e) => setApiKeyValue(e.target.value)}
onFocus={() => setApiKeyFocused(true)}
onBlur={() => setApiKeyFocused(false)}
placeholder={
connectorConfig.auth.mode === 'apiKey' && connectorConfig.auth.placeholder
? connectorConfig.auth.placeholder
Expand Down Expand Up @@ -345,17 +348,7 @@ export function AddConnectorModal({ open, onOpenChange, knowledgeBaseId }: AddCo
>
<Checkbox
checked={!disabledTagIds.has(tagDef.id)}
onCheckedChange={(checked) => {
setDisabledTagIds((prev) => {
const next = new Set(prev)
if (checked) {
next.delete(tagDef.id)
} else {
next.add(tagDef.id)
}
return next
})
}}
onCheckedChange={() => {}}
/>
Comment thread
waleedlatif1 marked this conversation as resolved.
<span className='text-[var(--text-primary)]'>{tagDef.displayName}</span>
<span className='text-[11px] text-[var(--text-muted)]'>
Expand Down
2 changes: 0 additions & 2 deletions ...rkspace/[workspaceId]/knowledge/[id]/components/connectors-section/connectors-section.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,8 +130,6 @@ export function ConnectorsSection({

return (
<div className='mt-[16px]'>
<h2 className='font-medium text-[14px] text-[var(--text-secondary)]'>Connected Sources</h2>

{error && (
<p className='mt-[8px] text-[12px] text-[var(--text-error)] leading-tight'>{error}</p>
)}
Expand Down
6 changes: 5 additions & 1 deletion apps/sim/connectors/github/github.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,11 @@ export const githubConnector: ConnectorConfig = {
version: '1.0.0',
icon: GithubIcon,

auth: { mode: 'oauth', provider: 'github', requiredScopes: ['repo'] },
auth: {
mode: 'apiKey',
label: 'Personal Access Token',
placeholder: 'ghp_xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx',
},

configFields: [
{
Expand Down
2 changes: 1 addition & 1 deletion apps/sim/connectors/gmail/gmail.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,7 @@ export const gmailConnector: ConnectorConfig = {
auth: {
mode: 'oauth',
provider: 'google-email',
requiredScopes: ['https://www.googleapis.com/auth/gmail.readonly'],
requiredScopes: ['https://www.googleapis.com/auth/gmail.modify'],
Comment thread
waleedlatif1 marked this conversation as resolved.
},

configFields: [
Expand Down
2 changes: 1 addition & 1 deletion apps/sim/connectors/google-calendar/google-calendar.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ export const googleCalendarConnector: ConnectorConfig = {
auth: {
mode: 'oauth',
provider: 'google-calendar',
requiredScopes: ['https://www.googleapis.com/auth/calendar.readonly'],
requiredScopes: ['https://www.googleapis.com/auth/calendar'],
Comment thread
waleedlatif1 marked this conversation as resolved.
},

configFields: [
Expand Down
2 changes: 1 addition & 1 deletion apps/sim/connectors/google-sheets/google-sheets.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ export const googleSheetsConnector: ConnectorConfig = {
auth: {
mode: 'oauth',
provider: 'google-sheets',
requiredScopes: ['https://www.googleapis.com/auth/spreadsheets.readonly'],
requiredScopes: ['https://www.googleapis.com/auth/drive'],
Comment thread
waleedlatif1 marked this conversation as resolved.
},

configFields: [
Expand Down
1 change: 1 addition & 0 deletions apps/sim/connectors/reddit/reddit.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,7 @@ export const redditConnector: ConnectorConfig = {
auth: {
mode: 'oauth',
provider: 'reddit',
requiredScopes: ['read'],
},

configFields: [
Expand Down
Loading