fix(workflows): validate cancellation terminal writes

Author: icecrasher321

apps/sim/lib/execution/cancel-workflow-execution.test.ts

@@ -1613,16 +1613,19 @@ describe('cancelWorkflowExecution', () => {
   })
 
   it('updates execution log status in DB when durably recorded', async () => {
-    const mockWhere = vi.fn().mockResolvedValue(undefined)
+    const mockReturning = vi.fn().mockResolvedValue([{ status: 'cancelled' }])
+    const mockWhere = vi.fn(() => ({ returning: mockReturning }))
     const mockSet = vi.fn(() => ({ where: mockWhere }))
     databaseMock.db.update.mockReturnValueOnce({ set: mockSet })
     mockMarkExecutionCancelled.mockResolvedValue({
       durablyRecorded: true,
       reason: 'recorded',
     })
 
-    await POST(makeRequest(), makeParams())
+    const response = await POST(makeRequest(), makeParams())
 
+    expect(response.status).toBe(200)
+    await expect(response.json()).resolves.toMatchObject({ success: true, reason: 'recorded' })
     expect(databaseMock.db.update).toHaveBeenCalled()
     expect(mockSet).toHaveBeenCalledWith({
       status: 'cancelled',
@@ -1633,7 +1636,8 @@ describe('cancelWorkflowExecution', () => {
   })
 
   it('updates execution log status in DB when locally aborted', async () => {
-    const mockWhere = vi.fn().mockResolvedValue(undefined)
+    const mockReturning = vi.fn().mockResolvedValue([{ status: 'cancelled' }])
+    const mockWhere = vi.fn(() => ({ returning: mockReturning }))
     const mockSet = vi.fn(() => ({ where: mockWhere }))
     databaseMock.db.update.mockReturnValueOnce({ set: mockSet })
     mockMarkExecutionCancelled.mockResolvedValue({
@@ -1642,8 +1646,13 @@ describe('cancelWorkflowExecution', () => {
     })
     mockAbortManualExecution.mockReturnValue(true)
 
-    await POST(makeRequest(), makeParams())
+    const response = await POST(makeRequest(), makeParams())
 
+    expect(response.status).toBe(200)
+    await expect(response.json()).resolves.toMatchObject({
+      success: true,
+      reason: 'redis_unavailable',
+    })
     expect(databaseMock.db.update).toHaveBeenCalled()
     expect(mockSet).toHaveBeenCalledWith({
       status: 'cancelled',