fix(copilot): require workflow id for cancellation

Author: j15z

apps/sim/lib/copilot/generated/tool-catalog-v1.ts

@@ -1629,13 +1629,9 @@ export const CancelWorkflowRun: ToolCatalogEntry = {
         description:
           'Required workflow execution ID returned by run_workflow with async:true or found with query_logs. This identifies a workflow run, not an agent invocation or chat request.',
       },
-      workflowId: {
-        type: 'string',
-        description:
-          'Workflow ID that owns the execution. Optional; omit it to target the current workflow. Pass it when cancelling a run from another workflow.',
-      },
+      workflowId: { type: 'string', description: 'Required workflow ID that owns the execution.' },
     },
-    required: ['executionId'],
+    required: ['workflowId', 'executionId'],
   },
   requiredPermission: 'write',
   requiresApproval: true,

apps/sim/lib/copilot/generated/tool-schemas-v1.ts

@@ -1571,11 +1571,10 @@ export const TOOL_RUNTIME_SCHEMAS: Record<string, ToolRuntimeSchemaEntry> = {
         },
         workflowId: {
           type: 'string',
-          description:
-            'Workflow ID that owns the execution. Optional; omit it to target the current workflow. Pass it when cancelling a run from another workflow.',
+          description: 'Required workflow ID that owns the execution.',
         },
       },
-      required: ['executionId'],
+      required: ['workflowId', 'executionId'],
     },
     resultSchema: undefined,
   },

apps/sim/lib/copilot/tools/handlers/param-types.ts

@@ -61,9 +61,9 @@ export interface RunWorkflowParams {
 }
 
 export interface CancelWorkflowRunParams {
-  workflowId?: string
+  workflowId: string
   /** The workflow execution ID returned by run_workflow or query_logs. */
-  executionId?: string
+  executionId: string
 }
 
 export interface RunWorkflowUntilBlockParams {

apps/sim/lib/copilot/tools/handlers/workflow/mutations.test.ts

@@ -3,6 +3,7 @@
  */
 import { beforeEach, describe, expect, it, vi } from 'vitest'
 import type { ExecutionContext } from '@/lib/copilot/request/types'
+import type { CancelWorkflowRunParams } from '@/lib/copilot/tools/handlers/param-types'
 import { WorkflowRunAlreadyTerminalError } from '@/lib/execution/workflow-run-already-terminal-error'
 
 const { mocks } = vi.hoisted(() => ({
@@ -226,12 +227,25 @@ describe('workflow mutation Copilot adapters', () => {
   })
 
   it('requires an execution ID before attempting workflow-run cancellation', async () => {
-    const result = await executeCancelWorkflowRun({ workflowId: 'workflow-1' }, context)
+    const result = await executeCancelWorkflowRun(
+      { workflowId: 'workflow-1' } as CancelWorkflowRunParams,
+      context
+    )
 
     expect(result).toEqual({ success: false, error: 'executionId is required' })
     expect(mocks.executeWorkflowUseCase).not.toHaveBeenCalled()
   })
 
+  it('requires a workflow ID even when the execution context contains one', async () => {
+    const result = await executeCancelWorkflowRun(
+      { executionId: 'execution-1' } as CancelWorkflowRunParams,
+      context
+    )
+
+    expect(result).toEqual({ success: false, error: 'workflowId is required' })
+    expect(mocks.executeWorkflowUseCase).not.toHaveBeenCalled()
+  })
+
   it.each([
     {
       label: 'until',

apps/sim/lib/copilot/tools/handlers/workflow/mutations.ts

@@ -289,7 +289,7 @@ export async function executeCancelWorkflowRun(
   context: ExecutionContext
 ): Promise<ToolCallResult> {
   try {
-    const workflowId = params.workflowId || context.workflowId
+    const workflowId = params.workflowId
     if (!workflowId) {
       return { success: false, error: 'workflowId is required' }
     }