Always set the NAS identifier; if not set fall back to the hostname #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #28 +/- ##
========================================
Coverage 0.00% 0.00%
+ Complexity 26 25 -1
========================================
Files 1 1
Lines 91 89 -2
========================================
+ Misses 91 89 -2 🚀 New features to boost your workflow:
|
Collaborator
|
You should entirely comment out line 160 (nasIpAddress). With the updated upstream code, it is very complex to determine whether the RADIUS request will be sent as IPv4 or IPv6; if it happens to be IPv6, setting NAS-IP-Address will fail. |
Member
Author
|
Tagged v2.1.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that the NAS identifier is always set to meet standards compliance when no NAS-IP-Address is set