Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve MX and SPF domain handling #2246

Merged
merged 4 commits into from
Oct 2, 2024

Conversation

cquintana92
Copy link
Collaborator

⚠️ Please review with attention ⚠️

This PR performs the following changes:

  1. Move out logic from the dns.html template file into the controller, passing the values to be used instead of calculating them in the template.
  2. Offer new functions that return the expected MX and SPF records on the CustomDomainValidation class.
  3. Make use of the aforementioned functions during the MX and SPF verification process.
  4. Encapsulate the MX records into a MxRecord class instead of a Tuple[int, str].
  5. Adapt the tests accordingly to these changes and add some new ones.

@cquintana92 cquintana92 force-pushed the fix/improve-mx-domain-handling-and-verification branch from c39cf0a to 23fadf0 Compare October 2, 2024 13:12
@acasajus acasajus merged commit b97a1dd into master Oct 2, 2024
6 checks passed
@acasajus acasajus deleted the fix/improve-mx-domain-handling-and-verification branch October 2, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants