Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: refactor dns to improve testability #2224

Merged
merged 3 commits into from
Sep 17, 2024
Merged

chore: refactor dns to improve testability #2224

merged 3 commits into from
Sep 17, 2024

Conversation

cquintana92
Copy link
Collaborator

This PR performs the following changes:

  1. Encapsulate all the DNS logic into classes that implement base class methods.
  2. Remove global functions in favour of passed-on implementations (IoC).
  3. Add tests to app/custom_domain_validation.py before extending the code.

@cquintana92 cquintana92 merged commit f6708dd into master Sep 17, 2024
6 checks passed
@cquintana92 cquintana92 deleted the chore/refactor-dns-to-improve-testability branch September 17, 2024 14:15
@cquintana92 cquintana92 added the enhancement New feature or request label Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acasajus acasajus acasajus approved these changes

@nguyenkims nguyenkims Awaiting requested review from nguyenkims nguyenkims is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cquintana92 @acasajus