Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: extract custom domain utils to a service #2215

Merged
merged 1 commit into from
Sep 13, 2024
Merged

feat: extract custom domain utils to a service #2215

merged 1 commit into from
Sep 13, 2024

Conversation

cquintana92
Copy link
Collaborator

This PR performs the following changes:

  1. Offer a new function that loads a dictionary from an env var
  2. Allow to define partner domains (not in use yet)
  3. Extracting logic from the controller into a service so it can be reused
  4. Move the DMARC record to app.constants

acasajus
acasajus reviewed Sep 13, 2024
View reviewed changes
app/config.py Outdated Show resolved Hide resolved
acasajus
acasajus reviewed Sep 13, 2024
View reviewed changes
app/config.py Outdated Show resolved Hide resolved
@cquintana92 cquintana92 merged commit 647c569 into master Sep 13, 2024
6 checks passed
@cquintana92 cquintana92 deleted the feature/custom-domain-utils branch September 13, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acasajus acasajus acasajus approved these changes

@nguyenkims nguyenkims Awaiting requested review from nguyenkims nguyenkims is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cquintana92 @acasajus