Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine activation code generation. #1225

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Refine activation code generation. #1225

wants to merge 2 commits into from

Commits on Aug 10, 2022

  1. Refine activation code generation. 

    Previously, activation code genaration invoked a redudant `str()` conversion
(`secrets.cohice(string.digits)` already returns a string).
Also, secrets.choice was called six times, which is slower than just one call.
I hope this refinement make the code more readable and faster.
    @weakish
    weakish committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    cdcaf97 View commit details
    Browse the repository at this point in the history

  2. Extract activation code length as a constant. 

    suggested by @acasajus
    @weakish
    weakish committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    e2b147f View commit details
    Browse the repository at this point in the history