Skip to content

Commit

Permalink
Send the alias creation time in the alias creation event
Browse files Browse the repository at this point in the history
  • Loading branch information
acasajus committed Sep 13, 2024
1 parent 025d4fe commit 00ec804
Show file tree
Hide file tree
Showing 5 changed files with 19 additions and 14 deletions.
24 changes: 12 additions & 12 deletions app/events/generated/event_pb2.py

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 4 additions & 2 deletions app/events/generated/event_pb2.pyi
Original file line number Diff line number Diff line change
Expand Up @@ -16,16 +16,18 @@ class UserDeleted(_message.Message):
def __init__(self) -> None: ...

class AliasCreated(_message.Message):
__slots__ = ("alias_id", "alias_email", "alias_note", "enabled")
__slots__ = ("alias_id", "alias_email", "alias_note", "enabled", "created_at")
ALIAS_ID_FIELD_NUMBER: _ClassVar[int]
ALIAS_EMAIL_FIELD_NUMBER: _ClassVar[int]
ALIAS_NOTE_FIELD_NUMBER: _ClassVar[int]
ENABLED_FIELD_NUMBER: _ClassVar[int]
CREATED_AT_FIELD_NUMBER: _ClassVar[int]
alias_id: int
alias_email: str
alias_note: str
enabled: bool
def __init__(self, alias_id: _Optional[int] = ..., alias_email: _Optional[str] = ..., alias_note: _Optional[str] = ..., enabled: bool = ...) -> None: ...
created_at: int
def __init__(self, alias_id: _Optional[int] = ..., alias_email: _Optional[str] = ..., alias_note: _Optional[str] = ..., enabled: bool = ..., created_at: _Optional[int] = ...) -> None: ...

class AliasStatusChanged(_message.Message):
__slots__ = ("alias_id", "alias_email", "enabled")
Expand Down
1 change: 1 addition & 0 deletions app/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -1681,6 +1681,7 @@ def create(cls, **kw):
alias_email=new_alias.email,
alias_note=new_alias.note,
enabled=True,
created_at=int(new_alias.created_at.timestamp),
)
EventDispatcher.send_event(user, EventContent(alias_created=event))

Expand Down
1 change: 1 addition & 0 deletions proto/event.proto
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ message AliasCreated {
string alias_email = 2;
string alias_note = 3;
bool enabled = 4;
uint32 created_at = 5;
}

message AliasStatusChanged {
Expand Down
1 change: 1 addition & 0 deletions tests/events/test_sent_events.py
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ def test_fire_event_on_alias_creation():
assert alias.email == alias_created.alias_email
assert "" == alias_created.alias_note
assert alias.enabled == alias_created.enabled
assert int(alias.created_at.timestamp) == alias_created.created_at


def test_fire_event_on_alias_creation_with_note():
Expand Down

0 comments on commit 00ec804

Please sign in to comment.