Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add glTF icon #11297

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

Conversation

MichaelHinrichs
Copy link
Contributor

image
I don't know why the M in the ™ is cut off in this preview. I promise it's not like this in the svg.

Popularity metric:
https://www.similarweb.com/website/khronos.org/#overview
https://github.com/KhronosGroup/glTF
https://trends.google.com/trends/explore?date=all&q=%2Fg%2F11c2j8dkh8&hl=en
"glTF is the 'JPEG of 3D'" - This page

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

I have made sure that everything is to the standards of both Khronos® Group and Simple Icons.

@simple-icons simple-icons bot added the new icon Issues or pull requests for adding a new icon label Jun 21, 2024
@anhthang
Copy link
Contributor

anhthang commented Jun 22, 2024

Your SVG is not optimized with SVGO and the view box is 0 0 25 25. That's why the M is cut off in the preview

@MichaelHinrichs
Copy link
Contributor Author

Your SVG is not optimized with SVGO

Yes it is. Did I get a setting wrong?

@uncenter
Copy link
Member

Your SVG is not optimized with SVGO

Yes it is. Did I get a setting wrong?

It's mostly fine, I think the only outstanding issue is you have an extra version="1.1" attribute that isn't needed. Please address the viewbox issue as well as @anhthang pointed out.

@MichaelHinrichs
Copy link
Contributor Author

Oh, also just now seeing that i got the viewbox wrong. But wouldn't making it smaller cut off more of the logo?

@uncenter
Copy link
Member

Oh, also just now seeing that i got the viewbox wrong. But wouldn't making it smaller cut off more of the logo?

You can edit the viewbox in the text file from 25x25 to 24x24, open it in your editor, and resize the icon to fit in the proper 24x24 viewbox. Nothing will be lost.

@MichaelHinrichs
Copy link
Contributor Author

New preview.
image

_data/simple-icons.json Outdated Show resolved Hide resolved
@uncenter
Copy link
Member

See the lint errors please.

@MichaelHinrichs
Copy link
Contributor Author

I'm not sure I understand. Do I need to capitalize the c in the hex code?

@uncenter
Copy link
Member

I'm not sure I understand. Do I need to capitalize the c in the hex code?

Yes. See https://github.com/simple-icons/simple-icons/blob/develop/CONTRIBUTING.md#7-update-the-json-data-for-simpleiconsorg.

icons/glTF.svg Outdated Show resolved Hide resolved
@uncenter
Copy link
Member

Please see the linter errors. Your precision level is too high, try optimizing with 4 or 5.

icons/gltf.svg Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants