Fix logic error when zeros_outside was True#410
Merged
jcapriot merged 3 commits intosimpeg:mainfrom Dec 2, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #409.
Previously it would skip doing anything at all if zeros_outside was True, (even if the value was inside the mesh) on the interpolation matrix for the
cell_centered,face_andedge_interpolation matrices. This fixes the logic by computing interpolation for zeros_outside=False (as before) and also continuing if the zeros_outside is True, but the location was inside.Still need to add some tests here really quick