Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue 376 #378

Merged
merged 4 commits into from
Mar 21, 2025
Merged

Fix issue 376 #378

merged 4 commits into from
Mar 21, 2025

Conversation

kujaku11
Copy link
Collaborator

@kujaku11 kujaku11 commented Mar 17, 2025 •
edited
Loading

This PR will close issue #376 on circular dependencies. The fix is moving RunSummary and KernelDataset to mth5 from mtpy-v2. This will allow users to access those objects without using mtpy-v2, it also removes any dependency of aurora on mtpy-v2.

  • Update imports from mtpy to mth5

@kujaku11 kujaku11 added the bug Something isn't working label Mar 17, 2025
@kujaku11 kujaku11 requested a review from kkappler March 17, 2025 19:24
@kujaku11 kujaku11 changed the base branch from main to patches March 17, 2025 23:56
kkappler
kkappler approved these changes Mar 21, 2025
View reviewed changes
Copy link
Collaborator

@kkappler kkappler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! thanks @kujaku11

@kkappler kkappler merged commit d6a676d into patches Mar 21, 2025
8 checks passed
@kkappler kkappler deleted the processing_fix_issue_376 branch March 21, 2025 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkappler kkappler kkappler approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kujaku11 @kkappler