Fix issue 364 #375
Closed
Fix issue 364 #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- also, pytest was complaining about it locally, and it doesn't seem worth looking into
- these don't hurt and make the flow slightly more robust
- make prewhitening correction depend only on keyword, not all decimation params
- this requires reinstalling mt_metadata over mtpy - I'm not sure whether or not to comment out the aurora install .. ... this may get quite complicated. This push is a test to see how complicated
…imation in FCDecimation
- rename extra_pre_fft_detrend_type to per_window_detrend_type - add explicit assignment of per_window_detrend_type="linear" in config creator
- minor changes to doc
- if tests pass we should be able to delete pipelines/fourier_coefficients
- these tools are now in mth5
- update tests and add a test for test_nan_handling
- both aurora's run_ts_to_stft, and mth5's run_ts_to_stft_scipy return spectre.Spectrogram objects now. - These will (hopefully) be propagated further into the workflow over time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an unpushed local commit when I merged the last PR. Trying to fix that.