Skip to content

Conversation

@ColmTalbot
Copy link
Contributor

@ColmTalbot ColmTalbot commented Nov 7, 2025

This is some initial regression tests. There are some things that are not included yet (mostly in using the results, they are just uplaoded as artifacts.)

Remaining questions:

  • How do I calculate flux ratios?
  • ...

Based on #86

@ColmTalbot ColmTalbot marked this pull request as draft November 7, 2025 15:41
@JBorrow
Copy link
Member

JBorrow commented Nov 14, 2025

I'd start looking here about how the injection process works: https://github.com/simonsobs/sotrplib/blob/main/sotrplib/sims/source_injector.py#L42

@ColmTalbot ColmTalbot force-pushed the initial-regression-tests branch from 55f6d5b to c7f75ac Compare November 18, 2025 20:20
@ColmTalbot
Copy link
Contributor Author

It looks like there's a mismatch in the flux units at some stage because the flux ratios are all coming out at 1000.

image

@ColmTalbot
Copy link
Contributor Author

This is currently taking about 10 minutes to run in the CI. Are we happy with that runtime?

@ColmTalbot ColmTalbot marked this pull request as ready for review November 19, 2025 14:38
@ColmTalbot
Copy link
Contributor Author

@JBorrow @axf295 it looks like I can't officially request reviews.

My current plan is to add a follow up after this is merged that will do some automatic tracking of the uploaded artifacts (post a comment on PRs and possibly send some kind of notification if there's a significant regression on main).

@JBorrow
Copy link
Member

JBorrow commented Nov 21, 2025

Any idea why the new workload is not running in the CI?

@JBorrow
Copy link
Member

JBorrow commented Nov 21, 2025

Oh, wait, it did. Never mind.

@JBorrow JBorrow merged commit bf261fe into simonsobs:main Nov 21, 2025
2 checks passed
@axf295
Copy link
Collaborator

axf295 commented Nov 21, 2025

I think you can merge main and that should fix the flux mismatch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants