Repository navigation
Fix preproc db updating - #1769
Merged
Merged
Conversation
added 2 commits
October 22, 2026 12:22
mmccrackan
marked this pull request as ready for review
October 22, 2026 20:37
msilvafe
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
overwriteoption incleanup_mandbin preprocessing was not passed into the Db batch manageradd_entryso it always skips updating the entry even if the archive h5 file gets updated. Even if it was passed, it would have been ignored since the Db manager only checks if the entry exists when inspected and not whetherreplaceisTrue. This means the Db will always refer back to the old preprocessing archive entry if it was in a different file (this happened when trying to backfill withoverwrite=Trueon site).