Gp/feat/multipass make ml map #1035
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iparask
requested review from
mhasself,
amaurea,
chervias and
tanaybhandarkar
chervias
requested changes
Dec 2, 2024
chervias
reviewed
Dec 9, 2024
| # And add it to the mapmaker | ||
| # FIXME: How to handle multipass here? | ||
| with mapmaking.mark(f"add_obs {name}"): | ||
| signal_estimate = None if pass_ind == 0 else mapmaker.transeval(name, obs, mapmaker_prev, x_prev) |
There was a problem hiding this comment.
I tested the mapmaker with 2 passes. Once the second pass started, it failed in this line like this
Traceback (most recent call last):
File "/pscratch/sd/c/chervias/cmbenv-perlmutter-so2/bin/so-site-pipeline", line 8, in <module>
sys.exit(main())
File "/pscratch/sd/c/chervias/cmbenv-perlmutter-so2/lib/python3.10/site-packages/sotodlib/site_pipeline/cli.py", line 109, in main
module.main(**vars(args))
File "/pscratch/sd/c/chervias/cmbenv-perlmutter-so2/lib/python3.10/site-packages/sotodlib/site_pipeline/make_ml_map.py", line 297, in main
signal_estimate = None if pass_ind == 0 else mapmaker.transeval(name, obs, mapmaker_prev, x_prev)
File "/pscratch/sd/c/chervias/cmbenv-perlmutter-so2/lib/python3.10/site-packages/sotodlib/mapmaking/ml_mapmaker.py", line 143, in transeval
ssig.transeval(id, obs, osig, oval, tod=tod)
File "/pscratch/sd/c/chervias/cmbenv-perlmutter-so2/lib/python3.10/site-packages/sotodlib/mapmaking/ml_mapmaker.py", line 359, in transeval
pmap.from_map(dest=tod, signal_map=map, comps=self.comps)
File "/pscratch/sd/c/chervias/cmbenv-perlmutter-so2/lib/python3.10/site-packages/sotodlib/coords/pmat.py", line 451, in from_map
proj.from_map(self._prepare_map(signal_map), self._get_asm(), signal=dest, comps=comps)
File "/pscratch/sd/c/chervias/cmbenv-perlmutter-so2/sotoast2/lib/python3.10/site-packages/so3g/proj/wcs.py", line 679, in from_map
return super().from_map(src_map, assembly, signal, comps)
File "/pscratch/sd/c/chervias/cmbenv-perlmutter-so2/sotoast2/lib/python3.10/site-packages/so3g/proj/wcs.py", line 321, in from_map
signal_out = projeng.from_map(
RuntimeError: Tiling problem (index 11): Projector expects tile but it is missing.
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings the multipass capabilities of ML mapmaker to the site pipeline script. It also does some lint changes to increase readability.