Skip to content
This repository has been archived by the owner on Apr 5, 2024. It is now read-only.

Updating logic, simplifying requirements, and adding shuffle all #1

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

johnpacheco1
Copy link

@johnpacheco1 johnpacheco1 commented Oct 14, 2022

First, I just wanted to thank you @simonsickle for creating this! I recently got a tesla and have been annoyed by Tidal's lack of a shuffle feature. I was going to attempt to write a similar program to what you have created when I happened on this!

Changes:

README.md

  • Added docs for ElectricShuffleAll.py

requirements.txt

  • Some of the packages were causing issues with installation so I pared it down to only what is necessary

ElectricShuffle.py

  • Changed logic to accommodate selecting from no shuffled playlists only
    • Made it so script does not print out playlists named "- Electrified"
    • Shuffling a playlist always deletes and creates a new "- Electrified" playlist
  • Delete now actually deletes the shuffled playlist

**ElectricShuffleAll.py"

  • Includes logic for using refresh token to auto-refresh token on run
    • As long as it is run at least once every week you won't have to re-login
  • Iterates over and shuffles all playlists

@johnpacheco1 johnpacheco1 changed the title Updating logix, simplifying requirements, and adding shuffle all Updating logic, simplifying requirements, and adding shuffle all Oct 14, 2022
Copy link
Owner

@simonsickle simonsickle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! One small request if you don't mind, though!

For maintainability and code quality, could you make the code copied to the "all" script shared (maybe through a module and classes).

That's a pretty big ask, so if you don't feel like taking that on let me know and I'll add a TODO for me to revisit in the future.

Thanks for the contribution

@simonsickle simonsickle added enhancement New feature or request documentation Improvements or additions to documentation labels Oct 16, 2022
@johnpacheco1
Copy link
Author

I will give it a shot!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants