Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extended tile set store #34

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Extended tile set store #34

wants to merge 17 commits into from

Conversation

tordanik
Copy link
Contributor

@tordanik tordanik commented Jun 6, 2022 •
edited
Loading

This PR improves handling of extended tile sets. Notably, it encourages multiple map elements (nodes, ways, relations) to reference the same extended set by ...

  • using the same indices, and refraining from modifying existing sets
  • adding the "primary" tile to the extended set as well, thus allowing e.g. all nodes of a way to use the same set even if they are in different tiles themselves
  • looking at the most recently added set for reuse potential.

A new ExtendedTileSetStore class handles adding and retrieving tile sets (growing the backing array as needed, much as an ArrayList).

This pull request also includes some cleanup work and is based on #32.

simonpoole and others added 17 commits March 14, 2022 17:17
@simonpoole
Rearrange encoding to increase numbers of bits available as index
6b5a942
@simonpoole
Fix a couple of minor code smells
8907554
@simonpoole
Use methods from TileCoord for encoding / decoding
df8a3ab
@simonpoole
Rename method to something indicating what it actually does
4160c73
@simonpoole
Ignore NN bits if we have an extended list
3e6d71d
@simonpoole
Ignore more test data
b4eaf0a
@simonpoole
Output some timing information on tile creation
9e1dd84
@simonpoole
Migrate from standard Collections to fastutils
192fc62
@simonpoole
Final HashMap migration
a1a54d0
@tordanik
Fix javadoc after migration to fastutils
4a09174
@tordanik
Replace toList with IntArrayList constructor, avoid creating it twice
394730c
@tordanik
Represent sets of tile coordinates as IntSet
58c5116 
Remove methods for merging sets and duplicate-free addition
@tordanik
Reuse parseNnBits in appendNeighbours
ddbdc7f
@tordanik
Reduce duplication of extended sets
a760d72 
* Extract management of extended sets into a separate class
* Try to reuse extended sets, e.g. for nodes of the same way
@tordanik
Refactor AbstractOsmMap.decode to accept one value instead of many
3f073dd
@tordanik
Add the home tile to the extended set, improving reuse
7aaa493
@tordanik
Delete the outdated TODO.md and HEAPMAP.md documents
9fe4860
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tordanik @simonpoole