-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add custom carb, fat & protein goals #124
base: develop
Are you sure you want to change the base?
Conversation
I broke deleteUserActivityItem because I cant fetch the userEntity there |
@schumischumi I've been able to test your changes and have some feedback. i would have expected the custom carb/fat/protein to be under the calculations (top right gear > calculations). it just seems the natural place for it. There I would expect to choose from a list of standards or enter my custom ratios. but found your proposed custom ratios, under the profile ? (for now, i accept and continue) Then I went to edit them and found the method a bit cumbersome.
(by test I mean use the app, not review code) |
thanks for the response and sry it took me a while. I will be blocked by private matters the coming 1.5 weeks but I hope after that I can keep on working on this.
true. I put it into the profile because the other values that will be configured during the initial setup are also there. so I was able to do a quick copy & past. I uploaded an apk (locally built debug apk) and scanned it. but please check for yourself and install it on your own risk |
Fixes #123
tests are still missing.
I'm no dart dev so please review very critically :-)