Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix x509 type conflict (happened after tls update to 1.7) #63

Merged
merged 1 commit into from
Jul 4, 2023
Merged

Fix x509 type conflict (happened after tls update to 1.7) #63

merged 1 commit into from
Jul 4, 2023

Conversation

Miezhiko
Copy link
Contributor

@Miezhiko Miezhiko commented Jul 4, 2023

Changelog for tls-1.7.0
Major version up because "crypton" is used instead of "cryptonite"

without this commit:

     Couldn't match expected type Data.X509.CertificateStore.CertificateStore
                  with actual type x509-store-1.6.9:Data.X509.CertificateStore.CertificateStore
      NB: Data.X509.CertificateStore.CertificateStore
            is defined in Data.X509.CertificateStore
                in package crypton-x509-store-1.6.9
          x509-store-1.6.9:Data.X509.CertificateStore.CertificateStore
            is defined in Data.X509.CertificateStore
                in package x509-store-1.6.9
     In the sharedCAStore field of a record
      In the clientShared field of a record
      In the expression:
        (NT.defaultParamsClient (T.unpack host) "443")
          {NT.clientSupported = def
                                  {NT.supportedCiphers = NT.ciphersuite_default},
           NT.clientShared = def {NT.sharedCAStore = certStore}}
    |
136 |                   { NT.sharedCAStore = certStore
    |                                        ^^^^^^^^^
    ```

@simmsb simmsb merged commit 4eb3642 into simmsb:master Jul 4, 2023
1 check failed
@simmsb
Copy link
Owner

simmsb commented Jul 4, 2023

Looks good, thanks

@Miezhiko Miezhiko deleted the patch-1 branch July 4, 2023 13:24
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants