Implement Ruan Mei #312
Open
Implement Ruan Mei #312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* init + skeleton + data * implement stats, attack * implement (unfinished) skill, talent Additional notes: * merged some modifiers while keeping same functionality for sim
* finish skill, talent * add ult (unfinished), traces, eidolons * moved several modifiers and functions to trace.go/eidolon.go Additional notes: * merged some modifiers while keeping same functionality for sim * ult requires implementation of `AllDamagePEN` * technique unimplemented, requires changes in the core to be implemented properly
* continue ult Additional notes: * no implementation of `ImprintReset` logic because unknown * need to implement new listeners first
* finish ult Additional notes: * known bug: if dispelled, CD mod won't be removed (requires `OnDispel` listener) * `ImprintReset` logic unimplemented since no functionality has been discovered * waiting for implementation of `AllDamagePEN` prop * waiting for implementation of `BreakExtend`
* add `OnDispel` listener * add `BreakExtend` listener * add `AbortFlags` to ult insert * set `CanDispel` to true
* change E2 to check for `Break` flag * change `E4Listener` to listen to `OnBeforeBeingBreak` * refactor E4 application to helper function
* update `TalentBreakListener` and `UltDebuff` to use `RemoveWhenSourceDead` flag instead of doing subscription to `TargetDeath` event
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
incomplete:
* missingimplementedUltDebuffCDbeing removed whenUltDebuffis dispelled (requiresOnDispellistener: AddDispelemit #307 )* missingimplementedUltDebuffdoing its effect (requiresBreakExtendlogic: AddBreakExtendlogic #311 )* E4 waits for AddimplementedOnBeforeBeingBreaklistener and fixOnBreakExtendlistener #334Additional notes:
ImprintResetlogic unimplemented since no functionality has been discovered