Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: propagate result code on Producer::flushMessages err #183

Merged
merged 1 commit into from
Sep 17, 2024
Merged

feat: propagate result code on Producer::flushMessages err #183

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/Clients/Producer/KafkaProducer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
use RdKafka\ProducerTopic;
use RuntimeException;

use function assert;
use function sprintf;

use const RD_KAFKA_PARTITION_UA;
Expand Down Expand Up @@ -76,8 +77,10 @@
}
}

assert($result !== null);

if ($result !== RD_KAFKA_RESP_ERR_NO_ERROR) {
throw new RuntimeException('Was unable to flush, messages might be lost!');
throw new RuntimeException('Was unable to flush, messages might be lost!', $result);

Check warning on line 83 in src/Clients/Producer/KafkaProducer.php

View check run for this annotation

Codecov / codecov/patch

src/Clients/Producer/KafkaProducer.php#L83 

Added line #L83 was not covered by tests
}
}
}
Loading