Compatibility between FiberIntegrator and MultiGeometry #2331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 12, 2024 13:33
for more information, see https://pre-commit.ci
EdgarGF93
changed the title
kif
reviewed
Nov 13, 2024
src/pyFAI/multi_geometry.py
Outdated
| :return: regrouped intensity and unit arrays | ||
| :rtype: Integrate2dResult | ||
| """ | ||
| if "npt_horizontal" in kwargs: |
There was a problem hiding this comment.
Since this block of code is duplicated twice, it would make sense to have it in a (private) method. One may need to update the locals dict ...
kif
reviewed
Nov 13, 2024
src/pyFAI/multi_geometry.py
Outdated
| fi.reset_integrator(incident_angle=unit_ip.incident_angle, | ||
| tilt_angle=unit_ip.tilt_angle, | ||
| sample_orientation=unit_ip.sample_orientation) | ||
|
|
There was a problem hiding this comment.
Always convert method to an instance of IntegrationMethod and then check the attributes. see how it is done l433
|
First, we merge #2324 and the code for this PR will be much lighter |
|
Needs also #2336 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #2304
Wrapping the fiber methods inside the MultiGeometry class