Fetch opaque datasets with h5grove as binary #1587
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is in preparation for #1554.
Opaque datasets were so far fetched with h5grove as JSON, which led to back-end errors for datasets that cannot be encoded to strings (like
datetime64_scalar
).I now fetch opaque datasets as binary and return
UInt8Array
values fromH5GroveProvider
for consistency withH5WasmProvider
.With [email protected], this change leads to 422 errors for all opaque datasets. This will be fixed with silx-kit/h5grove#89 and a new release of h5grove. This PR therefore constitutes somewhat a breaking change.
While I'm at it, I also improve the display of
UInt8Array
values slightly inRawVis
by simply callingtoString()
instead ofJSON.stringify()
: