Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI test for Python 3.12 #98

Merged
merged 2 commits into from
Aug 29, 2024
Merged

Add CI test for Python 3.12 #98

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
64fa27b
Add CI test for Python 3.12
loichuder Aug 29, 2024
1464c9c
Update action versions in CI
loichuder Aug 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions .github/workflows/lint-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,19 @@ on:
jobs:
lint_test:
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
python-version: ['3.8', '3.12']

steps:
- name: Checkout 🏷️
uses: actions/checkout@v2
uses: actions/checkout@v4

- name: Install Python 🐍
uses: actions/setup-python@v2
uses: actions/setup-python@v5
with:
python-version: '3.8'
python-version: ${{ matrix.python-version }}
architecture: 'x64'

- name: Install dependencies ⚙️
Expand Down
4 changes: 2 additions & 2 deletions test/base_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,7 +388,7 @@ def test_meta_on_valid_ext_link(self, server, resolve_links):
h5file["ext_link"] = h5py.ExternalLink(source_file, "data")

response = server.get(
f"/meta/?{urlencode({'file': filename, 'path': '/ext_link', 'resolve_links': f'{resolve_links}'})}"
f"/meta/?{urlencode({'file': filename, 'path': '/ext_link', 'resolve_links': resolve_links.value})}"
)
content = decode_response(response)

Expand Down Expand Up @@ -539,7 +539,7 @@ def test_meta_on_broken_soft_link(self, server, resolve_links):
with h5py.File(server.served_directory / filename, mode="w") as h5file:
h5file[link_path] = h5py.SoftLink("not_an_entity")

url = f"/meta/?{urlencode({'file': filename, 'path': link_path, 'resolve_links': f'{resolve_links}'})}"
url = f"/meta/?{urlencode({'file': filename, 'path': link_path, 'resolve_links': resolve_links.value})}"

# It should return 404 if trying to resolve the broken link
if resolve_links == LinkResolution.ALL:
Expand Down