Skip to content

Commit

Permalink
Add CI test for Python 3.12
Browse files Browse the repository at this point in the history
  • Loading branch information
loichuder committed Aug 29, 2024
1 parent 116a629 commit 01a1d1c
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 3 deletions.
7 changes: 6 additions & 1 deletion .github/workflows/lint-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,19 @@ on:
jobs:
lint_test:
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
python-version: ['3.8', '3.12']

steps:
- name: Checkout 🏷️
uses: actions/checkout@v2

- name: Install Python 🐍
uses: actions/setup-python@v2
with:
python-version: '3.8'
python-version: ${{ matrix.python-version }}
architecture: 'x64'

- name: Install dependencies ⚙️
Expand Down
4 changes: 2 additions & 2 deletions test/base_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -388,7 +388,7 @@ def test_meta_on_valid_ext_link(self, server, resolve_links):
h5file["ext_link"] = h5py.ExternalLink(source_file, "data")

response = server.get(
f"/meta/?{urlencode({'file': filename, 'path': '/ext_link', 'resolve_links': f'{resolve_links}'})}"
f"/meta/?{urlencode({'file': filename, 'path': '/ext_link', 'resolve_links': resolve_links.value})}"
)
content = decode_response(response)

Expand Down Expand Up @@ -539,7 +539,7 @@ def test_meta_on_broken_soft_link(self, server, resolve_links):
with h5py.File(server.served_directory / filename, mode="w") as h5file:
h5file[link_path] = h5py.SoftLink("not_an_entity")

url = f"/meta/?{urlencode({'file': filename, 'path': link_path, 'resolve_links': f'{resolve_links}'})}"
url = f"/meta/?{urlencode({'file': filename, 'path': link_path, 'resolve_links': resolve_links.value})}"

# It should return 404 if trying to resolve the broken link
if resolve_links == LinkResolution.ALL:
Expand Down

0 comments on commit 01a1d1c

Please sign in to comment.