NEW Add new page for testing elemental blocks on a page. #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for behat testing in silverstripe/silverstripe-elemental#911
I tried using a pre-existing subclass of
Pageand applying the extension to it in the behat test, but there seems to be some weird bug with the way we do behat tests where the extension from the previous test was being sort-of-but-not-really applied toPageif I did that. I don't really understand exactly what was happening, but this resolves that problem and lets us do the test.Specifically, it's required if doing a behat test with one page that doesn't have the
ElementalPageExtensionand another page that does.Parent issue