ENH Update code to reflect changes in silverstripe/admin #11463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
May need silverstripe/silverstripe-admin#1850 for CI to go green. Please merge that first.
Note that while we shouldn't have this coupling here, the coupling as already here. Resolving that coupling issue is way out of scope and probably includes moving gridfield into its own separate module with its own css and js pulled out of silverstripe/admin.... a card for another day.
Issue
LeftAndMaininto its own abstract class silverstripe-admin#1762