NEW DBField validation #11397
Closed
NEW DBField validation #11397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
emteknetnz
commented
Sep 23, 2024
| $validator->validationError( | ||
| $this->name, | ||
| _t('SilverStripe\\Forms\\EmailField.VALIDATION', 'Please enter an email address'), | ||
| 'validation' | ||
| $validationResult->getMessages()[0]['message'], |
There was a problem hiding this comment.
Getting the message from the $validationResult rather than simply using $message in case we want to use the special symfony strings such as {{ value }} in the future
emteknetnz
commented
Sep 23, 2024
| return $result; | ||
| } | ||
|
|
||
| public function scaffoldFormField(?string $title = null, array $params = []): ?FormField |
There was a problem hiding this comment.
This was copy pasted from DBVarchar, just changing the TextField to an EmailField
emteknetnz
commented
Sep 23, 2024
src/ORM/FieldType/DBField.php
Outdated
| @@ -43,6 +45,10 @@ | |||
| */ | |||
| abstract class DBField extends ModelData implements DBIndexable | |||
| { | |||
| public function validate(): ValidationResult | |||
There was a problem hiding this comment.
Signature matches DataObject::validate() for consistency
This method should be moved further down the class
emteknetnz
force-pushed
the
pulls/6/dbfield-validation
branch
4 times, most recently
from
98198a5
to
2bf5c61
Compare
emteknetnz
force-pushed
the
pulls/6/dbfield-validation
branch
from
2bf5c61
to
fe46daa
Compare
|
Closed in favor of #11402 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #11391
To share the email validation logic between the EmailField::validate() and DBEmail::validate() I've simply used the symfony email constraint
There are now 3x different validate() methods
Validator should really be renamed to FormValidator for clarify. A (Form)Validator has a ValidationResult as a property
TODO: