API Use new class_description configuration #1272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
commented
Nov 11, 2024
| return _t(__CLASS__ . '.Description', $description); | ||
| } | ||
| return ''; | ||
| Deprecation::notice('5.3.0', 'Use i18n_classDescription() instead.'); |
There was a problem hiding this comment.
Was deprecated in 5.3.0 so keeping that version there, though the advice is now different.
This was referenced Nov 11, 2024
emteknetnz
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs silverstripe/silverstripe-framework#11461 for CI to go green - please merge that PR first.
Uses new configuration and method added in silverstripe/silverstripe-framework#11461
Issue
SiteTreeinCMSMainsilverstripe-cms#2947